Skip to content

Latest commit

 

History

History
87 lines (59 loc) · 3.53 KB

CONTRIBUTING.md

File metadata and controls

87 lines (59 loc) · 3.53 KB
Raw

How to contribute

Communication

All communication must follow our Code of Conduct.

Creating issues

If any part of the project has a bug or documentation mistakes, please let us know by opening an issue. All bugs and mistakes are considered very seriously, regardless of complexity.

Before creating an issue, please check that an issue reporting the same problem does not already exist. To make the issue accurate and easy to understand, please try to create issues that are:

  • Unique -- do not duplicate existing bug report. Deuplicate bug reports will be closed.
  • Specific -- include as much details as possible: which version, what environment, what configuration, etc.
  • Reproducible -- include the steps to reproduce the problem. Some issues might be hard to reproduce, so please do your best to include the steps that might lead to the problem.
  • Isolated -- try to isolate and reproduce the bug with minimum dependencies. It would significantly slow down the speed to fix a bug if too many dependencies are involved in a bug report. Debugging external systems that rely on this project is out of scope, but guidance or help using the project itself is fine.
  • Scoped -- one bug per report. Do not follow up with another bug inside one report.

It may be worthwhile to read Elika Etemad’s article on filing good bug reports before creating a bug report.

Maintainers might ask for further information to resolve an issue.

Contribution flow

This is a rough outline of what a contributor's workflow looks like:

  • Create an issue
  • Fork the project
  • Create a branch from where to base the contribution -- this is almost always main
  • Push changes into a branch of your fork
  • Submit a pull request
  • Respond to feedback from project maintainers

Creating new issues is one of the best ways to contribute. You have no obligation to offer a solution or code to fix an issue that you open. If you do decide to try and contribute something, please submit an issue first so that a discussion can occur to avoid any wasted efforts.

Legal requirements

In order to protect both you and ourselves, all commits will require an explicit sign-off that acknowledges the DCO.

Sign-off commits end with the following line:

Signed-off-by: Random J Developer <random@developer.example.org>

This can be done by using the --signoff (or -s for short) git flag to append this automatically to your commit message. If you have already authored a commit that is missing the signed-off, you can amend or rebase your commits and force push them to GitHub.

Common tasks

Linting Protobuf Definitions

All Protobuf code is managed using buf. You can lint the definitions by executing:

buf build && buf lint

⚠️ Warnings ⚠️

  • The version field found in various buf YAML configuration is actually schema of the YAML of the file and is not related to the version of the definitions.
  • buf build and buf generate do entirely different things. Building compiles definitions and ensures semantic validity. Generate builds and then produces actual source code according to buf.gen.yaml.