Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wish: warn on insecure algorithms #66

Closed
markstos opened this issue Feb 6, 2020 · 4 comments
Closed

wish: warn on insecure algorithms #66

markstos opened this issue Feb 6, 2020 · 4 comments
Milestone

Comments

@markstos
Copy link

markstos commented Feb 6, 2020

Hello,

I maintain the passport-saml library which has this library as a dependency.

We'd also like to move away from insecure algorithms. However, a SAML service provider may integrate with dozens of Identity providers. How can we know if insecure algorithms are in use? It seems simply disabling them may break some integrations.

It would be helpful if there was an option to allow insecure algorithms as before, but issue a warning if they are used. This change would be safe to deploy and would allow collecting log data to see if any integrations are using insecure algorithms. We could then notify our partners about the problem so that we could later disable the insecure algorithms without breaking anything.

Describe the ideal solution

One option is to always start issuing warning if insecure algorithms are used.

Another option is to add a boolean flag to opt-in (or out) of having the warnings be issued.

Thanks!

@gkwang
Copy link
Contributor

gkwang commented Mar 23, 2020

@markstos would console.warn() suffice or do you have other approaches in mind?

@markstos
Copy link
Author

@gkwang console.warn() would be sufficient. That will generate log output I can search through.

Thanks.

@gkwang
Copy link
Contributor

gkwang commented Mar 25, 2020

This is now included in the v1.1.0 release.

@gkwang gkwang closed this as completed Mar 25, 2020
@markstos
Copy link
Author

Related ticket for passport-saml: node-saml/passport-saml#429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants