Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade axios dependency to latest verison #200

Closed
mikelax opened this issue Dec 1, 2020 · 5 comments · Fixed by #206 or #208
Closed

Upgrade axios dependency to latest verison #200

mikelax opened this issue Dec 1, 2020 · 5 comments · Fixed by #206 or #208
Labels
help wanted

Comments

@mikelax
Copy link

mikelax commented Dec 1, 2020

Describe the problem you'd like to have solved

The latest version of axios is currently 0.21.0. This library should upgrade to the latest version of axios, assuming the plan is to stick with axios as opposed to switching to another library for making HTTP requests.

Describe the ideal solution

Upgrade to axios version 0.21.0
@davidpatrick
Copy link
Contributor

Hey @mikelax if you have the time, PRs are welcome, otherwise I will get to this on our next release 👍

@davidpatrick
Copy link
Contributor

@mikelax is there something you need from this axios 0.21.0 for this library? Or is this just a general dependency bump request?

@mikelax
Copy link
Author

mikelax commented Dec 10, 2020

@davidpatrick at first I thought it was related to a snyk cve, but after double checking I don't see anything, so it can be considered a general bump. I did notice that version 0.20.0 seems to be a big change so maybe there will be a gain.

@davidpatrick davidpatrick mentioned this issue Dec 11, 2020
Merged
@lauriharpf
Copy link

@davidpatrick, #206 updates to "axios": "^0.20.0", but should this issue still be kept open?

Doing an npm init to create an empty project and npm add axios@^0.20.0 gives this warning:

npm WARN deprecated axios@0.20.0: Critical security vulnerability fixed in v0.21.1. For more information, see axios/axios#3410

Should we update to axios@^0.21.1?

@mikelax
Copy link
Author

mikelax commented Dec 23, 2020

I agree, as long as we are upgrading the lib might as well go to the latest version and fix the cve.

72636c added a commit to 72636c/node-jwks-rsa that referenced this issue Dec 29, 2020
@72636c
Bump Axios to ^0.21.1
fe184ea 
This version fixes an SSRF vulnerability:

https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-28168

The changelog since 0.20.0 seems reasonable:

https://github.com/axios/axios/blob/a64050a6cfbcc708a55a7dc8030d85b1c78cdf38/CHANGELOG.md#0211-december-21-2020

Closes auth0#200.
@72636c 72636c mentioned this issue Dec 29, 2020
Merged
lbalmaceda pushed a commit that referenced this issue Dec 29, 2020
@72636c
Bump Axios to ^0.21.1 (#208)
3bbe93f 
This version fixes an SSRF vulnerability:

https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-28168

The changelog since 0.20.0 seems reasonable:

https://github.com/axios/axios/blob/a64050a6cfbcc708a55a7dc8030d85b1c78cdf38/CHANGELOG.md#0211-december-21-2020

Closes #200.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
3 participants
@davidpatrick @mikelax @lauriharpf