-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Changes between 8.5.1
& 9.0.0
introduce a circular dependency
#865
Comments
Hi, |
Same issue using Vite (Rollup under the hood), only with prod build. |
This is a bug in rollup and/or semver See - npm/node-semver#381 |
Taking a (non-dev-)dependency on a buggy package could be considered a bug 😅 Maybe we can check Node support in another way? I'm not entirely sure I understand the 9.0.0 PR, but it seems that on older versions of Node, the checks based on |
Description
Changes between
8.5.1
&9.0.0
introduce acircular dependency
Reproduction
Bundle w/
rollup
8.5.1
(previous version) & then9.0.0
.You'd see no issues w/
8.5.1
.And w/
9.0.0
you'd see the following in your console:The text was updated successfully, but these errors were encountered: