Refactor tests related to jti and jwtid #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ziluvatar Looks like the build needs to be restarted, when you get a moment. The Node 7 build seems to have stalled. |
|
I figured that could happen with these PRs. I will rebase against the latest changes when I get a chance. |
MitMaro
force-pushed
the
jti-claim-tests
branch
from
59b6c87
to
af64026
Compare
This change extracts all tests related to the jti claim and the jwtid option into a single test file. Additional tests were added that were missing.
MitMaro
force-pushed
the
jti-claim-tests
branch
from
af64026
to
e5721b3
Compare
|
@ziluvatar I forgot to ping you when I did the rebase a few weeks ago. I've rebase again against the latest from master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next PR for #492
This change extracts all tests in the existing test files related to
jwtidandjtiinto a single test file. Several other tests are also added that were missing from the existing files.All references to
jwtidandjtihave been removed from the existing test files.As always, suggestions or missing tests are more than welcome!
Coverage Master
Coverage Branch