Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong typing for algorithms #285

Closed
fsanzv opened this issue Apr 30, 2022 · 1 comment
Closed

Wrong typing for algorithms #285

fsanzv opened this issue Apr 30, 2022 · 1 comment

Comments

@fsanzv
Copy link

fsanzv commented Apr 30, 2022

Description

If you do not provide ´algorithms´ option you get an exception in run time.

I know this is in the doc: https://github.com/auth0/express-jwt#required-parameters but the typings used for ´algorithms´ option comes from jsonwebtoken package and there the ´algorithms´ is defined as optional.

I think this typing should be overridden in jwt to avoid confusion.
@jfromaniello
Copy link
Member

jfromaniello commented May 2, 2022 •
edited

good catch! fixed in v7.6.2

jfromaniello added a commit that referenced this issue May 2, 2022
@jfromaniello
remove undefined from algorhitms fix #285
587238b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfromaniello @fsanzv