Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routes not awaited #388

Open
6 tasks done
illegalnumbers opened this issue Mar 5, 2024 · 1 comment
Open
6 tasks done

Routes not awaited #388

illegalnumbers opened this issue Mar 5, 2024 · 1 comment
Labels
bug This points to a verified bug in the code

Comments

@illegalnumbers
Copy link

Checklist

  • The issue can be reproduced in the auth0-vue sample app (or N/A).
  • I have looked into the Readme, Examples, and FAQ and have not found a suitable solution or answer.
  • I have looked into the API documentation and have not found a suitable solution or answer.
  • I have searched the issues and have not found a suitable solution or answer.
  • I have searched the Auth0 Community forums and have not found a suitable solution or answer.
  • I agree to the terms within the Auth0 Code of Conduct.

Description

Route calls, such as this

router.push(this.pluginOptions?.errorPath || '/');
and
router.push(target);
, should be awaited as they are async.

Reproduction

Code is not awaited

Additional context

No response

auth0-vue version

latest master

Vue version

any

Which browsers have you tested in?

Chrome

@illegalnumbers illegalnumbers added the bug This points to a verified bug in the code label Mar 5, 2024
@frederikprijck
Copy link
Member

frederikprijck commented Mar 6, 2024

Thanks for reaching out. The Vue Router docs is also very explicit about not awaiting this in the basic use-case, see: https://router.vuejs.org/guide/essentials/navigation.html. That said, they do have a section to call out the possibility to await route changes, see: https://router.vuejs.org/guide/advanced/navigation-failures.html

Can you help us understand what the problem is you are facing that would be solved by awaiting this?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This points to a verified bug in the code
Projects
None yet
Development

No branches or pull requests

2 participants