Skip to content

Remove unnecessary dependencies and move others to dev-dependencies #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 12, 2022

Conversation

jmac105
Copy link
Contributor

@jmac105 jmac105 commented Aug 11, 2022

✏️ Changes

Removing dependencies which are not unused, and moving other packages from dependencies into dev-dependencies such as test assertion libraries.
Resolves #625

🎯 Testing

No tests added or removed, tests are all passing locally.

✅🚫 This change has unit test coverage

✅🚫 This change has integration test coverage

✅🚫 This change has been tested for performance

@jmac105 jmac105 requested a review from a team as a code owner August 11, 2022 12:08
willvedd
willvedd previously approved these changes Aug 11, 2022
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! You beat me to it, I already had this exact set of changes ready to push. Anyways, appreciate you addressing this.

@jmac105
Copy link
Contributor Author

jmac105 commented Aug 11, 2022

Not sure why e2e tests are failing, as far as I can tell it does not seem to be related to my changes?

@willvedd
Copy link
Contributor

@jmac105 Yeah, I think it has to do with this being a forked PR. I'm looking into it now and will re-run locally but anticipate your changes to be valid. Once I confirm, I'll go ahead and merge.

Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to your changes, I removed cross-env dependency as it isn't being used anymore. Was able to confirm that e2e test failures are the result of secrets not being passed through for forked PRs, will need to address that sometime in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency on ts-node
2 participants