New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test code which uses reflect doesn't handle incomplete code well #16
Comments
@ribasushi - do you remember what code did this, by any chance? I'm trying to come up with an example to help replicate this. I vaguely remember it was something to do with implementing a |
Actually, I'm starting to wonder if this was just another instance of the bug fixed in stretchr/testify#622 |
@autarch almost certainly yes - the text of the panic() was nearly identical |
Thanks for confirming. Once that PR is merged I think the bulk of these issues will go away. It just turns out that it's fairly easy for the exercise tests to tickle that particular bug. |
Fixed by updating the deps for the class exercises. |
If a student writes incomplete code that compiles and runs the tests, it's easy for the tests to panic. They probably need a lot more checks for
nil
all over the place.The text was updated successfully, but these errors were encountered: