search: duplicate package name with NO_COLOR

[cyrinux]

Hi,

with aurutils-git, NO_COLOR=true is broken.

the package name is duplicate.

$ NO_COLOR=true aur search -n -k NumVotes arch-secure-boot
aur/arch-secure-bootaur/arch-secure-boot 1.3.2-1 (+2 0.00%)
    UEFI Secure Boot for Arch Linux + btrfs snapshot recovery

$ aur search -n -k NumVotes arch-secure-boot
aur/arch-secure-boot 1.3.2-1 (+2 0.00%)
    UEFI Secure Boot for Arch Linux + btrfs snapshot recovery

Regards

[Earnestly]

Does your terminal emulator support OSC8 hyperlinks? At any rate, it seems like the repeated print is from that, especially as it's specifically that part of the output.

[cyrinux]

Hmm, i'm using kitty and it get the support here kovidgoyal/kitty#68, with color enable I got the link when mouse over aur/arch-secure-boot and with NO_COLOR=true i can get the link on the second duplicate aur/arch-secure-boot.
I feel like we should disable the link when NO_COLOR enable ?

[Earnestly]

Yes, you should it's always used. Not quite sure why it's only doubling the name, as it's not missing elements that would otherwise interfere with printf(1)'s implicit looping feature.

[AladW]

The issue appears to be that the package name is printed a second time when ALL_OFF is undefined i.e. if colorize() was not run. The function should return in that case:

if [[ ! -v ALL_OFF ]]; then
    printf "%s" "$mesg"
    return  # <---
fi

That said, I'm not sure NO_COLOR should disable the link since it's only about "color" escapes (which are e.g. annoying when debugging with set -x).

[AladW]

Fixed with #996