Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search is broken in the documentation #57

Closed
chausner-audeering opened this issue Apr 28, 2021 · 8 comments · Fixed by #76
Closed

Search is broken in the documentation #57

chausner-audeering opened this issue Apr 28, 2021 · 8 comments · Fixed by #76
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@chausner-audeering
Copy link

chausner-audeering commented Apr 28, 2021

The search is broken in the documentation, e.g.: https://audeering.github.io/audb/search.html?q=full_path&check_keywords=yes&area=default gives a JavaScript error:

Uncaught ReferenceError: Stemmer is not defined
    query https://audeering.github.io/audb/_static/searchtools.js:158
    setIndex https://audeering.github.io/audb/_static/searchtools.js:98
    <anonymous> https://audeering.github.io/audb/search.html?q=full_path&check_keywords=yes&area=default line 2 > injectedScript:1

We had this issue a while ago with other packages and it was fixed there by updating audeering-sphinx-theme or one of the other packages if I remember correctly.

@hagenw
Copy link
Member

hagenw commented Apr 28, 2021

I guess you cannot remember where we fixed it, because I cannot.

@hagenw hagenw added bug Something isn't working documentation Improvements or additions to documentation labels Apr 28, 2021
@chausner-audeering
Copy link
Author

I don't remember either. :( I suggest to look for a package where the search works and then check whether different versions of sphinx packages are used.

@hagenw
Copy link
Member

hagenw commented Apr 28, 2021

I will. It could also be that this is affected by the order we load the different plugins in docs/conf.py as I remember that I solved some issue that way.

@hagenw
Copy link
Member

hagenw commented Apr 29, 2021

So far, I haven't found a single documentation where the search is still working.

@hagenw
Copy link
Member

hagenw commented Apr 29, 2021

It's a bug in the underlying RTD theme, see sphinx-doc/sphinx#8591

One workaround would be to use sphinx<3.4.0 and to fix it see how we can incorporate readthedocs/sphinx_rtd_theme#1021

@chausner-audeering
Copy link
Author

Hmm, can't we just update the version of the RTD theme that we use?

@hagenw
Copy link
Member

hagenw commented Apr 29, 2021

Hmm, can't we just update the version of the RTD theme that we use?

No, it's not that easy, the newer version of the RTD theme brake a lot of other stuff in our theme, so we have switched to an older version, see audeering/sphinx-audeering-theme#30

@hagenw
Copy link
Member

hagenw commented May 3, 2021

This is now fixed with release 1.0.12 of sphinx-audeering-theme (audeering/sphinx-audeering-theme#31).
See https://audeering.github.io/sphinx-audeering-theme/search.html?q=test&check_keywords=yes&area=default

I will create a pull request to switch to the new version. You should do the same in other projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants