Skip to content
This repository was archived by the owner on Nov 9, 2024. It is now read-only.

fix(inlinePositioning): set ReferenceObject in onShow lifecycle hook #630

Merged
merged 2 commits into from
Oct 29, 2019
Merged

fix(inlinePositioning): set ReferenceObject in onShow lifecycle hook #630

merged 2 commits into from
Oct 29, 2019
+16 −19

Conversation

atomiks
Copy link
Owner

@atomiks atomiks commented Oct 29, 2019

Fixes #627

@atomiks
Copy link
Owner Author

atomiks commented Oct 29, 2019

Though, still doesn't work with @KubaJastrz's selection technique in #623.

Somehow it should work with this:

instance.popperInstance.reference = selection.getRangeAt(0);

@atomiks atomiks merged commit 7d84043 into master Oct 29, 2019
@atomiks atomiks deleted the fix/627 branch October 29, 2019 11:24
@amanagr
Copy link

amanagr commented Jun 18, 2021

instance.popperInstance.reference = selection.getRangeAt(0);

This doesn't work. instance.popperInstance is null in onShow function. It is defined in onShown but anyway, the intended purpose is not served.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inlinePositioning does not work with show() method
2 participants
@atomiks @amanagr