build problems with electron 5 beta

[tzarebczan]

Seeing this when running with latest electron 5 beta and v4.4.1:

C:\Users\SoloDolo\lbry-latest\lbry-desktop\node_modules\keytar>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "" rebuild )
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
⡀
Error output:
prebuild-install WARN install No prebuilt binaries found (target=5.0.0-beta.8 runtime=electron arch=x64 libc= platform=win32)
gyp info it worked if it ends with ok
gyp info using node-gyp@3.8.0
gyp info using node@10.15.3 | win32 | x64
gyp ERR! configure error```

[shiftkey]

@tzarebczan it's not clear to me whether you're able to build from source, but Electron 5 plans to ship with NodeJS 12, and I plan to publish a release targeting either one once they've made a stable release...

[shiftkey]

I'm able to build from source against the desired runtime on Windows, which should be the fallback behaviour when there's no prebuilt binary for it:

 $ npm_config_runtime=electron npm_config_disturl=https://atom.io/download/electron npm_config_target=5.0.0-beta.8 npm_config_arch=x64 npm install


> keytar@4.4.1 install C:\Users\shiftkey\src\node-keytar
> prebuild-install || node-gyp rebuild


C:\Users\shiftkey\src\node-keytar>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" rebuild )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  async.cc
  main.cc
c:\users\shiftkey\.node-gyp\5.0.0-beta.8\include\node\v8.h(4458): warning C4996: 'v8::WasmModuleObject::SerializedModule': was declared deprecated (compiling source file ..\src\main.cc) [C:\Users\shiftkey\src\node-keytar\build\keytar.vcxproj]
  c:\users\shiftkey\.node-gyp\5.0.0-beta.8\include\node\v8.h(4380): note: see declaration of 'v8::WasmModuleObject::SerializedModule' (compiling source file ..\src\main.cc)
c:\users\shiftkey\.node-gyp\5.0.0-beta.8\include\node\v8.h(4458): warning C4996: 'v8::WasmModuleObject::SerializedModule': was declared deprecated (compiling source file ..\src\async.cc) [C:\Users\shiftkey\src\node-keytar\build\keytar.vcxproj]
  c:\users\shiftkey\.node-gyp\5.0.0-beta.8\include\node\v8.h(4380): note: see declaration of 'v8::WasmModuleObject::SerializedModule' (compiling source file ..\src\async.cc)
c:\users\shiftkey\.node-gyp\5.0.0-beta.8\include\node\v8.h(10172): warning C4996: 'v8::Value::ToBoolean': was declared deprecated (compiling source file ..\src\main.cc) [C:\Users\shiftkey\src\node-keytar\build\keytar.vcxproj]
  c:\users\shiftkey\.node-gyp\5.0.0-beta.8\include\node\v8.h(2387): note: see declaration of 'v8::Value::ToBoolean' (compiling source file ..\src\main.cc)
c:\users\shiftkey\.node-gyp\5.0.0-beta.8\include\node\v8.h(10172): warning C4996: 'v8::Value::ToBoolean': was declared deprecated (compiling source file ..\src\async.cc) [C:\Users\shiftkey\src\node-keytar\build\keytar.vcxproj]
  c:\users\shiftkey\.node-gyp\5.0.0-beta.8\include\node\v8.h(2387): note: see declaration of 'v8::Value::ToBoolean' (compiling source file ..\src\async.cc)
c:\users\shiftkey\.node-gyp\5.0.0-beta.8\include\node\node_object_wrap.h(41): warning C4996: 'v8::PersistentBase<v8::Object>::IsNearDeath': was declared deprecated (compiling source file ..\src\async.cc) [C:\Users\shiftkey\src\node-keytar\build\keytar.vcxproj]
  c:\users\shiftkey\.node-gyp\5.0.0-beta.8\include\node\v8.h(571): note: see declaration of 'v8::PersistentBase<v8::Object>::IsNearDeath' (compiling source file ..\src\async.cc)
c:\users\shiftkey\src\node-keytar\node_modules\nan\nan_converters_43_inl.h(22): warning C4996: 'v8::Value::ToBoolean': was declared deprecated (compiling source file ..\src\async.cc) [C:\Users\shiftkey\src\node-keytar\build\keytar.vcxproj]
  c:\users\shiftkey\.node-gyp\5.0.0-beta.8\include\node\v8.h(2387): note: see declaration of 'v8::Value::ToBoolean' (compiling source file ..\src\async.cc)
c:\users\shiftkey\.node-gyp\5.0.0-beta.8\include\node\node_object_wrap.h(41): warning C4996: 'v8::PersistentBase<v8::Object>::IsNearDeath': was declared deprecated (compiling source file ..\src\main.cc)c:\users\shiftkey\src\node-keytar\node_modules\nan\nan_converters_43_inl.h(40): warning C4996: 'v8::Value::BooleanValue': was declared deprecated (compiling source file ..\src\async.cc) [C:\Users\shiftkey\src\node-keytar\build\keytar.vcxproj]

  c:\users\shiftkey\.node-gyp\5.0.0-beta.8\include\node\v8.h(571): note: see declaration of 'v8::PersistentBase<v8::Object>::IsNearDeath' (compiling source file ..\src\main.cc)c:\users\shiftkey\.node-gyp\5.0.0-beta.8\include\node\v8.h(2432): note: see declaration of 'v8::Value::BooleanValue' (compiling source file ..\src\async.cc)

c:\users\shiftkey\src\node-keytar\node_modules\nan\nan_converters_43_inl.h(22): warning C4996: 'v8::Value::ToBoolean': was declared deprecated (compiling source file ..\src\main.cc) [C:\Users\shiftkey\src\node-keytar\build\keytar.vcxproj]
  c:\users\shiftkey\.node-gyp\5.0.0-beta.8\include\node\v8.h(2387): note: see declaration of 'v8::Value::ToBoolean' (compiling source file ..\src\main.cc)
c:\users\shiftkey\src\node-keytar\node_modules\nan\nan_converters_43_inl.h(40): warning C4996: 'v8::Value::BooleanValue': was declared deprecated (compiling source file ..\src\main.cc) [C:\Users\shiftkey\src\node-keytar\build\keytar.vcxproj]
  c:\users\shiftkey\.node-gyp\5.0.0-beta.8\include\node\v8.h(2432): note: see declaration of 'v8::Value::BooleanValue' (compiling source file ..\src\main.cc)
c:\users\shiftkey\src\node-keytar\node_modules\nan\nan_object_wrap.h(24): warning C4996: 'v8::PersistentBase<v8::Object>::IsNearDeath': was declared deprecated (compiling source file ..\src\async.cc) [C:\Users\shiftkey\src\node-keytar\build\keytar.vcxproj]
  c:\users\shiftkey\.node-gyp\5.0.0-beta.8\include\node\v8.h(571): note: see declaration of 'v8::PersistentBase<v8::Object>::IsNearDeath' (compiling source file ..\src\async.cc)
c:\users\shiftkey\src\node-keytar\node_modules\nan\nan_object_wrap.h(127): warning C4996: 'v8::PersistentBase<v8::Object>::IsNearDeath': was declared deprecated (compiling source file ..\src\async.cc) [C:\Users\shiftkey\src\node-keytar\build\keytar.vcxproj]
  c:\users\shiftkey\.node-gyp\5.0.0-beta.8\include\node\v8.h(571): note: see declaration of 'v8::PersistentBase<v8::Object>::IsNearDeath' (compiling source file ..\src\async.cc)
c:\users\shiftkey\src\node-keytar\node_modules\nan\nan_object_wrap.h(24): warning C4996: 'v8::PersistentBase<v8::Object>::IsNearDeath': was declared deprecated (compiling source file ..\src\main.cc) [C:\Users\shiftkey\src\node-keytar\build\keytar.vcxproj]
  c:\users\shiftkey\.node-gyp\5.0.0-beta.8\include\node\v8.h(571): note: see declaration of 'v8::PersistentBase<v8::Object>::IsNearDeath' (compiling source file ..\src\main.cc)
c:\users\shiftkey\src\node-keytar\node_modules\nan\nan_object_wrap.h(127): warning C4996: 'v8::PersistentBase<v8::Object>::IsNearDeath': was declared deprecated (compiling source file ..\src\main.cc) [C:\Users\shiftkey\src\node-keytar\build\keytar.vcxproj]
  c:\users\shiftkey\.node-gyp\5.0.0-beta.8\include\node\v8.h(571): note: see declaration of 'v8::PersistentBase<v8::Object>::IsNearDeath' (compiling source file ..\src\main.cc)
c:\users\shiftkey\src\node-keytar\src\async.cc(193): warning C4996: 'v8::Object::Set': was declared deprecated [C:\Users\shiftkey\src\node-keytar\build\keytar.vcxproj]
  c:\users\shiftkey\.node-gyp\5.0.0-beta.8\include\node\v8.h(3259): note: see declaration of 'v8::Object::Set'
c:\users\shiftkey\src\node-keytar\src\async.cc(194): warning C4996: 'v8::Object::Set': was declared deprecated [C:\Users\shiftkey\src\node-keytar\build\keytar.vcxproj]
  c:\users\shiftkey\.node-gyp\5.0.0-beta.8\include\node\v8.h(3259): note: see declaration of 'v8::Object::Set'
  keytar_win.cc
  win_delay_load_hook.cc
     Creating library C:\Users\shiftkey\src\node-keytar\build\Release\keytar.lib and object C:\Users\shiftkey\src\node-keytar\build\Release\keytar.exp
  Generating code
  All 383 functions were compiled because no usable IPDB/IOBJ from previous compilation was found.
  Finished generating code
  keytar.vcxproj -> C:\Users\shiftkey\src\node-keytar\build\Release\\keytar.node
audited 1967 packages in 9.016s
found 38 vulnerabilities (1 low, 32 moderate, 5 high)
  run `npm audit fix` to fix them, or `npm audit` for details

[shiftkey]

Electron 5.0.0 is slated to be released April 23rd (based on https://electronjs.org/docs/tutorial/electron-timelines) so I'm going to use this issue to track ensuring we have a prebuild-friendly version ready to go after that...

[tzarebczan]

Thanks @shiftkey , appreciate the insights and help! I'll see if we can automatically build if the prebuilt is not available. This is tougher on Windows users, but should work fine on Mac/Nix.

[tzarebczan]

She's live! https://github.com/electron/electron/releases/tag/v5.0.0

[tzarebczan]

Will https://github.com/atom/node-keytar/releases/tag/v4.5.0 take care of the prebuilt modules?

[shiftkey]

@tzarebczan no, but #181 will

[shiftkey]

v4.6.0 should now prebuild fine for Electron 5