Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Upgrade Electron #22765

Closed
brettz9 opened this issue Jul 27, 2021 · 4 comments
Closed

Upgrade Electron #22765

brettz9 opened this issue Jul 27, 2021 · 4 comments

Comments

@brettz9
Copy link

brettz9 commented Jul 27, 2021

Summary

Upgrade to Electron 12+

Motivation

Earlier Node versions were buggy about ESM imports. Linter is causing our plugin eslint-plugin-jsdoc to crash (due to our depending on a package which uses nested exports paths).

(There is of course other good stuff in Node 14.)

Describe alternatives you've considered

Reverting our package to depend on a version with some bugs in the dependency we require.

Additional context

I know your upgrades are based on more than just one plug-in, but proper functioning of ESM is compelling as packages may now use this format natively and Node advertises support in its LTS versions (including for the Node 12 that you currently use, but that is an older less patched version).

@icecream17
Copy link
Contributor

It's not easy to upgrade - the actual pr for this is here: #22687

@brettz9
Copy link
Author

brettz9 commented Jul 27, 2021

Thanks. I think I might have found a workaround on our end. But would be great to come through.

@ioquatix
Copy link

ioquatix commented Apr 9, 2022

@brettz9 what was your workaround?

@brettz9
Copy link
Author

brettz9 commented Apr 9, 2022

In our case, the original package was amenable to exporting what we needed for now in a non-nested way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants