Nothing shows up for me

[aminya]

I tried apm install and apm rebuild. No error in the console.

[UziTech]

hmm it works for me. I did npm i && apm rebuild

Is there an error in the console?
What shell is it trying to open?

[UziTech]

I added some small fixes I was working on. Rebase and run npm i && apm rebuild and see if that works.

[aminya]

Any chance we get this fixed? I don't know how to test this package without being able to use it. We can ask other people to test this as well.

[UziTech]

I can't debug it because it works perfectly for me. Any chance you can find an error message or put a few debugger lines in the source to see where it fails?

[UziTech]

if you clone the repo and run the tests do they pass?

[UziTech]

what version of atom are you using?

[aminya]

The error in #5 (comment) was for some other package.

Let me put some debugger here and there.

[aminya]

what version of atom are you using?

I have tried it with both the latest stable and the version based on atom-ide-community master.

[aminya]

if you clone the repo and run the tests do they pass?

Yes, they pass!

[aminya]

Which function is responsible for launching the x-term? I don't see anything inside the opened pane.

[aminya]

@DeeDeeG Could you test this?

[UziTech]

Ok I finally got the community build working and terminal still seems to work fine for me so I am unable to debug this issue. @aminya it looks like this issue might be something specific to your setup.

Are you using pnpm to install the dependencies instead of npm? that could be the issue. When a user installs it atom will use the bundled version of npm to install the dependencies so I don't think we should use pnpm at all.

[DeeDeeG]

How do you get a terminal pane open? Is there a keyboard shortcut? A menu item? I've got this installed to my .atom/packages.

Thanks.

[UziTech]

I used command palette terminal:open

[DeeDeeG]

It's weird, I don't see anything in the command palette when I type "terminal". Hmm.

I did the following in the terminal folder that I cloned:

apm install
apm link

Then I launched Atom. That should be enough to install it, right?

[UziTech]

That should work. Is there a terminal folder (or symlink) in you packages directory?

[DeeDeeG]

Yep.

$ ls ~/.atom/packages/terminal
dist	     node_modules  package-lock.json  prettier.config.js  rollup.config.js  spec  tslint.json
LICENSE.txt  package.json  pnpm-lock.yaml     README.md		  script	    src
$ ls -l ~/.atom/packages/terminal
lrwxrwxrwx 1 [user] [group] 19 Aug 31 16:44 /home/[user]/.atom/packages/terminal -> /home/[user]/terminal

Also nothing showing up on Windows after installing. It shows in my list of community packages in Settings --> Packages, though.

[aminya]

x-terminal and terminal running together!

[UziTech]

The only thing I can think is an issue with pnpm.

Can you add some debugger statements to the code and figure out where it is failing?

[aminya]

I tried with pure apm.

Here is the debugger when running the open command. The set is empty for some reason!

[UziTech]

the set should be empty until workspace.open is called on the next line

[UziTech]

try placing a debugger in the createTerminal function in element.ts

[aminya]

It does not even hit the debugger in createTerminal

[aminya]

> (lastEntry && lastEntry.intersectionRatio === 1.0)
false

https://github.com/atom-ide-community/terminal/blob/0694079a7c445f9e15a0154ad10618806f3077e6/src/element.ts#L67

[aminya]

This patch solves the problem!!

- if (lastEntry && lastEntry.intersectionRatio === 1.0) { 
+ if (lastEntry) { 

[UziTech]

I wonder if the issue is in the intersection observer. Maybe it is not getting called.

The intersection observer is used to create the terminal once the terminal div is visible. Maybe for some reason it never becomes visible for you.

https://github.com/atom-ide-community/terminal/blob/0694079a7c445f9e15a0154ad10618806f3077e6/src/element.ts#L64-L83

[UziTech]

That patch might cause other problems try this instead

- if (lastEntry && lastEntry.intersectionRatio === 1.0) { 
+ if (lastEntry && lastEntry.intersectionRatio > 0.0) { 

[aminya]

That patch might cause other problems try this instead

- if (lastEntry && lastEntry.intersectionRatio === 1.0) { 
+ if (lastEntry && lastEntry.intersectionRatio > 0.0) { 

This works as well

[UziTech]

just curious what lastEntry.intersectionRatio is on your machine. It should always be 0.0 or 1.0

[aminya]

just curious what lastEntry.intersectionRatio is on your machine. It should always be 0.0 or 1.0

It is near to 1:

0.9984122514724731

[aminya]

Is there anything else about this? I think 7a05451 solves the problem finally!

[aminya]

Maybe we should say bigger than 0.5 so the error around 0 does not propagate into this. I don't know how this is calculated though.

[UziTech]

Weird, the threshold is set to 1 so it should only call the callback on 0 or 1.

> 0.0 should work. The only issue that could happen is something like this issue. but really what we want from that observer is to know that the terminal is not hidden (i.e. > 0).

[aminya]

If you are sure this does not become 0.001 or something this should work. This was a very strange bug fix 😅

[aminya]

Since this is a xterm issue, it might be worthwhile opening an issue and let them know

[UziTech]

That is one reason it is so weird. x-terminal works the same exact way but that worked for you and terminal did not with === 1.0

[aminya]

I opened an issue in xterm to let them know! If they use a boolean value, this will not happen.

[UziTech]

intersection observer is from chrome not xterm.

[UziTech]

Intersection Observer API

[aminya]

It would be good to use the isIntersecting property and fallback to the comparison only in case it is undefined. Similar to what xterm.js does.

xtermjs/xterm.js#3085 (comment)