Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use electron-rebuild in rebuild code #13

Open
aminya opened this issue Aug 27, 2020 · 1 comment
Open

Use electron-rebuild in rebuild code #13

aminya opened this issue Aug 27, 2020 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@aminya
Copy link
Member

aminya commented Aug 27, 2020

As discussed in atom-community/atom#111 and atom#889 (comment) the apm rebuild code is kind of wonky, and I can't trust it.

We should use electron-rebuild which is the official way to build Node modules against a specific Electron version.

Here is the documentation about Node modules in Electron.
electronjs.org/docs/tutorial/using-native-node-modules

@aminya aminya added bug Something isn't working enhancement New feature or request labels Aug 27, 2020
@DeeDeeG
Copy link
Member

DeeDeeG commented Aug 27, 2020

No comment on this approach.

For the record, this is what apm is already doing: https://www.electronjs.org/docs/tutorial/using-native-node-modules#using-npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants