New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide custom frame filtering options #37
Conversation
build failing because stable isn't available, nice :) I did not touch the formatting stuff, it should be ready for you to add the fancy pre/post frame filtering though |
Thanks for the great PR. I really didn't have to change a lot! For the spacers, I tried different things and thought that it would be cool to go with the zig-zag look that GitHub does when it truncates an enormously long issue: That's what it looks like with my current glyph selection in iTerm: I think it's okay, but I'll look into other glyphs. Alternatively, with the glyph I originally proposed: |
I'm not sure if it just takes some getting used but rn I think I prefer the second option |
Yeah, I'd go with the second one of those two as well. There's a quite significant lack of unicode characters for displaying medium height wavy/zigzag horizontal lines. I found two more options:
|
Sounds good, I agree with you that the second option here also looks pretty good but I don't have a strong preference. |
Alright, I just went with the somewhat more conservative Did I forget anything? From my side of things, this should be ready to merge. |
Nope, I think this ones good for me, also if you can make a release with this once it's merged I would be eternally grateful. |
I'll do a release tomorrow, after doing some additional testing. I want to make sure that no off-by-ones wre introduced -- having the wrong frames hidden would be a really major PITA for everyone trying to debug their app using the lib. |
closes #25