New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
main branch/v2.1.0 apparently no longer accepts a single extract block #403
Comments
If you could write an integration test, that would be great. I can revert the commit until I can make the new options work. |
Oh, I mean, it doesn't affect mkdocs-semiliterate until I actually update the mkdocs-simple-plugin dependency that it calls for. I just like to try to stay at the latest. My point is, it's not really necessary to revert; I can just wait to update. But in any case, I will go ahead and file a test-only PR on top of current main to add a test for the mkdocs.yml I use in mkdocs-semiliterate. |
OK, #405 is passing on main where I see you did revert the new config scheme (sorry about the trouble) and it fails in 2.1.0, so that should provide a test to ensure that the single-block possibility for the extract option is preserved. As ever, thanks for the effort you put into mkdocs-simple-plugin. |
Thanks! |
I am trying to update the mkdocs-semiliterate plugin built on mkdocs-simple to v2.1.0 and/or to the main branch (as you may recall, I prefer the plugin to itself explicitly extract from other files when producing documentation, rather than having the processing of those other files result in the creation of "snippet" files by side effect which are then included in the produced documentation by another mechanism -- hence I published mkdocs-semiliterate).
However, some of my tests now fail with
The relevant section of an mkdocs.yml where this happens is
(As you can see, each of these file patterns has just one extract block.)
The documentation for v2.1.0 still claims that a single block rather than a list of blocks is permitted, and there is still a line of code in the class Semiliterate constructor to handle this:
but I believe the new more-elaborated configuration schema for the plugin is causing mkdocs to reject semiliterate parameters with just one block rather than a list of them before the Semiliterate code ever gets to processing the extract parameter, cf. lines 181-190 of plugin.py:
I don't think the config schema in the code actually allows for both the "block or list of blocks" possibilities in the doc comments just above the code.
Would you like me to try to generate a PR to restore accepting just a block of settings rather than a list of them? Or do you prefer to handle this yourself?
The text was updated successfully, but these errors were encountered: