Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added loading animation #1730

Closed
wants to merge 3 commits into from
Closed

fix: added loading animation #1730

wants to merge 3 commits into from

Conversation

Gmin2
Copy link
Contributor

@Gmin2 Gmin2 commented Jan 8, 2024 •
edited by devilkiller-ag

Description

Added loading animation

Related Issue

Fixes #1725

Checklist

  • [✅] The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

@netlify Netlify
Copy link

netlify bot commented Jan 8, 2024 •
edited

❌ Deploy Preview for modelina failed.

Name Link
🔨 Latest commit db21f43
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/65d3273c1be6e20008b006dd

@Gmin2
Copy link
Contributor Author

Gmin2 commented Jan 8, 2024 •
edited

@devilkiller-ag @jonaslagoni should i add a animated loading icon ? or this is fine

@coveralls
Copy link

coveralls commented Jan 8, 2024 •
edited

Pull Request Test Coverage Report for Build 7957744854

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.32%
Totals Coverage Status
Change from base Build 7957589885: 0.0%
Covered Lines: 5997
Relevant Lines: 6328
💛 - Coveralls

devilkiller-ag
devilkiller-ag requested changes Jan 10, 2024
View reviewed changes
Copy link
Member

@devilkiller-ag devilkiller-ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Min2who, I can see the loading screen on both the input and output panel (I think this should only be on the output panel cc: @jonaslagoni) only when the website is loaded for the first time, but not when we change any setting. We also want the loading screen (on the output panel only) when we tweak settings.

@Gmin2
Copy link
Contributor Author

Gmin2 commented Jan 10, 2024

Hi @Min2who, I can see the loading screen on both the input and output panel (I think this should only be on the output panel cc: @jonaslagoni) only when the website is loaded for the first time, but not when we change any setting. We also want the loading screen (on the output panel only) when we tweak settings.

@devilkiller-ag can yu check it one more time the loading screen is only in the output screen only

@devilkiller-ag
Copy link
Member

Hi @Min2who, I can see the loading screen on both the input and output panel (I think this should only be on the output panel cc: @jonaslagoni) only when the website is loaded for the first time, but not when we change any setting. We also want the loading screen (on the output panel only) when we tweak settings.

@devilkiller-ag can yu check it one more time the loading screen is only in the output screen only

Here is the screenshot of my inspection. It's showing loading screen on both input editor panel and output panel.
Screenshot (325)

@Gmin2
Copy link
Contributor Author

Gmin2 commented Jan 10, 2024 •
edited

Hi @Min2who, I can see the loading screen on both the input and output panel (I think this should only be on the output panel cc: @jonaslagoni) only when the website is loaded for the first time, but not when we change any setting. We also want the loading screen (on the output panel only) when we tweak settings.

@devilkiller-ag can yu check it one more time the loading screen is only in the output screen only

Here is the screenshot of my inspection. It's showing loading screen on both input editor panel and output panel. Screenshot (325)

@devilkiller-ag this is not because of my changes that i have made
This loading is present in the website only

image

@jonaslagoni
Copy link
Sponsor Member

Any updates here? 👀

@Gmin2
Copy link
Contributor Author

Gmin2 commented Jan 26, 2024

Any updates here? 👀

@jonaslagoni can you review the pr .I have added the loading animation on the output screen

@jonaslagoni
Copy link
Sponsor Member

@Min2who all you @devilkiller-ag

@devilkiller-ag
Copy link
Member

Hi @Min2who @jonaslagoni, I will review the PR tomorrow as I don't have my laptop with me for now.
@Min2who Can you tick all the checklists in the PR description for then?

devilkiller-ag
devilkiller-ag reviewed Jan 29, 2024
View reviewed changes
Copy link
Member

@devilkiller-ag devilkiller-ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Min2who, I can't see the loading animation while changing the options (I used slow 3G network settings). Just to make sure I haven't missed anything can you send a screen recording of the loading animation that you created? Also mark the checkpoints in the PR description, once you feel they are handled correctly.

@devilkiller-ag
Copy link
Member

Any updates on this @Min2who?

@Gmin2
Copy link
Contributor Author

Gmin2 commented Feb 1, 2024

Any updates on this @Min2who?

Playground._.Modelina.-.Google.Chrome.2024-02-01.12-47-17.mp4

@devilkiller-ag
Copy link
Member

@Min2who That looks good to me. But don't you think we should also screen-load animation while changing the options 🤔?

2024-02-02.07-54-59.mp4

@jonaslagoni What do you think?

@jonaslagoni
Copy link
Sponsor Member

I agree @devilkiller-ag, its actually part of the issue description ✌️

When you change the input, open the playground, or change the settings, ...

@Gmin2
Copy link
Contributor Author

Gmin2 commented Feb 2, 2024

@Min2who That looks good to me. But don't you think we should also screen-load animation while changing the options 🤔?

2024-02-02.07-54-59.mp4
@jonaslagoni What do you think?

doing it 🙇‍♂️

@jonaslagoni
Copy link
Sponsor Member

Hey @Min2who have you had a chance to take a look at it? ✌️

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@devilkiller-ag
Copy link
Member

@jonaslagoni should I close this PR as we have not got any updates from @utnim2 since last two months?

@Gmin2
Copy link
Contributor Author

Gmin2 commented May 6, 2024

I am really sorry for it @jonaslagoni @devilkiller-ag

@Gmin2 Gmin2 closed this May 6, 2024
@devilkiller-ag devilkiller-ag mentioned this pull request May 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devilkiller-ag devilkiller-ag devilkiller-ag requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add loading animation for when playground generate models
4 participants
@Gmin2 @coveralls @devilkiller-ag @jonaslagoni