Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error on MIPS 32bit #664

Open
faulesocke opened this issue Jan 8, 2020 · 4 comments
Open

Build error on MIPS 32bit #664

faulesocke opened this issue Jan 8, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@faulesocke
Copy link

error[E0432]: unresolved import `std::sync::atomic::AtomicU64`
 --> [...]/async-std-1.4.0/src/task/task_id.rs:2:25
  |
2 | use std::sync::atomic::{AtomicU64, Ordering};
  |                         ^^^^^^^^^
  |                         |
  |                         no `AtomicU64` in `sync::atomic`
  |                         help: a similar name exists in the module: `AtomicU8

Unfortunately, according to the docs, 64bit atomic types are not available on 32bit mips architectures.

I've looked into the source location and two solutions to this come to my mind:

  1. use AtomicU32. This might or might not be okay on 32bit architectures.
  2. Rewrite this (for mips only) with blocking logic (i.e. keep the counter inside a mutex)

If someone tells me which one is the preferred solution, I can write a PR.

@yoshuawuyts
Copy link
Contributor

Related: #286

@yoshuawuyts yoshuawuyts assigned ghost Jan 9, 2020
@yoshuawuyts yoshuawuyts added the enhancement New feature or request label Jan 9, 2020
@faulesocke
Copy link
Author

Yep, this looks like it will solve my problem. Any estimations on when it might be ready?

@yoshuawuyts
Copy link
Contributor

@faulesocke this will mostly depend on availability of our team; we'll be sitting down to plan next steps for async-std next week, I'll be sure to bring this up.

@faulesocke
Copy link
Author

It looks like #286 was closed without being merged. Are there other plans to solve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants