Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace VecDeque with stream::from_iter in examples #430

Closed
yoshuawuyts opened this issue Oct 31, 2019 · 2 comments · Fixed by #447
Closed

Replace VecDeque with stream::from_iter in examples #430

yoshuawuyts opened this issue Oct 31, 2019 · 2 comments · Fixed by #447
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@yoshuawuyts
Copy link
Contributor

Now that rust-lang/futures-rs#1930 has landed, we're waiting on #415 to be merged. Once it's merged we should replace all uses of VecDeque with stream::from_iter so we're setup for the futures@0.3.0 release.

This should be a fairly mechanical change, and easy to pick up!

@yoshuawuyts yoshuawuyts added this to the 1.0.0 milestone Oct 31, 2019
@yoshuawuyts yoshuawuyts added the documentation Improvements or additions to documentation label Oct 31, 2019
@k-nasa
Copy link
Member

k-nasa commented Nov 1, 2019

Will I do this with #415 ?

@yoshuawuyts
Copy link
Contributor Author

@k-nasa I think we should merge that first, and create a follow-up PR to it that ports over the examples. That way we keep moving forward without having a single massive PR that does both things at once. Would you be willing to write the follow-up PR?

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants