Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

futures_util version needs to be 0.3.17 as a minimum #941

Closed
chipsenkbeil opened this issue Jun 4, 2022 · 0 comments
Closed

futures_util version needs to be 0.3.17 as a minimum #941

chipsenkbeil opened this issue Jun 4, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@chipsenkbeil
Copy link
Contributor

Expected Behavior

I can compile async-graphql version 4.0.1.

Actual Behavior

image

Steps to Reproduce the Problem

It looks like you have an import of futures_util::Stream instead of futures_util::stream::Stream here: https://github.com/async-graphql/async-graphql/blob/master/src/types/merged_object.rs#L6

The top-level re-export doesn't become available until futures_util 0.3.17. If you're supporting older versions, then I think this needs to be refactored! :)

Other details

It looks like there's a nightly feature of cargo that can be used to update the lock file to the. minimal versions of dependencies as defined in Cargo.toml so you can guarantee that your project compiles and tests successfully with those versions. I think it also impacts other crates, so may be a bit difficult to use.

cargo +nightly -Z minimal-versions update
cargo test --all --all-features

https://users.rust-lang.org/t/psa-please-specify-precise-dependency-versions-in-cargo-toml/71277

Specifications

  • Version: 4.0.1
  • Platform: Mac OS M1
  • Subsystem: Big Sur 11.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant