New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default value for env.intersphinx_named_inventory #136

Merged

saimn merged 1 commit into astropy:main from ConorMacBride:intersphinx-optional

Nov 17, 2021

Member

ConorMacBride commented Nov 16, 2021

If intersphinx isn't used env.intersphinx_named_inventory fails in smart_resolver.py. This PR uses getattr to allow the default value of {}.

Closes #110
Closes #122


          Set default value

de5fb5d

Signed-off-by: Conor MacBride <conor@macbride.me>

saimn approved these changes

View reviewed changes

Contributor

saimn left a comment

Thanks for the fix!

saimn merged commit 04d69ba into astropy:main

ConorMacBride deleted the intersphinx-optional branch

November 17, 2021 17:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment