Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sphinx_automodapi/automodsumm.py: address #132 #133

Merged
merged 1 commit into from Oct 23, 2021

Conversation

pkgw
Copy link
Contributor

@pkgw pkgw commented Jun 14, 2021

The members of ABC-derived classes were not being listed when they used a custom metaclass deriving from ABCMeta. The fix is not just test for exact equality of the ABCMeta metaclass, but subclassness.

Addresses #132.

The members of ABC-derived classes were not being listed when they used
a custom metaclass deriving from ABCMeta. The fix is not just test for
exact equality of the ABCMeta metaclass, but subclassness.
@pkgw
Copy link
Contributor Author

pkgw commented Jul 16, 2021

Ping?

@pkgw
Copy link
Contributor Author

pkgw commented Sep 20, 2021

@astrofrog Are you able to take a look at this?

@pkgw
Copy link
Contributor Author

pkgw commented Oct 23, 2021

@astrofrog This is your monthly ping on this PR!

@astrofrog astrofrog merged commit a867f77 into astropy:main Oct 23, 2021
@astrofrog
Copy link
Member

Sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants