Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Autosummary.warn() calls with logger.warning() for Sphinx 4 compatibility #129

Merged
merged 1 commit into from May 20, 2021
Merged

Replace Autosummary.warn() calls with logger.warning() for Sphinx 4 compatibility #129

merged 1 commit into from May 20, 2021

Conversation

JWCook
Copy link
Contributor

@JWCook JWCook commented May 15, 2021

Fixes #128.

@saimn
Copy link
Contributor

saimn commented May 20, 2021

Thanks @JWCook !

@saimn saimn merged commit 39609d0 into astropy:main May 20, 2021
@dstansby
Copy link

dstansby commented Nov 4, 2021

Are there any plans to get this into a release soon? I'm currently running into the issue that this PR fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saimn saimn saimn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not compatible with Sphinx 4: AttributeError: 'Automodsumm' object has no attribute 'warn'
3 participants
@JWCook @saimn @dstansby