Skip to content

Adding the doctest-remote-data directive to sphinx #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Jul 19, 2021

This one is required to fix #161 via astropy/sphinx-astropy#45

A changelog entry will be also required, and am happy to tag a new release to get rid of those fires. The only question is that should it be 0.9.1 or a new 0.10.0?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@bsipocz bsipocz added the bug label Jul 19, 2021
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be 0.9.1, as it is technically a bug fix.

Thanks for the fix!

@pllim
Copy link
Contributor

pllim commented Jul 19, 2021

p.s. Is there a way to test this?

@bsipocz
Copy link
Member Author

bsipocz commented Jul 19, 2021

@pllim - I suppose we could add a sphinx-build job to CI.

@pllim
Copy link
Contributor

pllim commented Jul 19, 2021

Ohhh this repo has no RTD set up!

@pllim
Copy link
Contributor

pllim commented Jul 19, 2021

Anyways, we can worry about that later. Let's put out the 🔥 first.

@bsipocz
Copy link
Member Author

bsipocz commented Jul 19, 2021

Yes, I suppose this is when simple things escalate 😅

@pllim pllim merged commit 5268715 into scientific-python:main Jul 19, 2021
@bsipocz bsipocz deleted the sphinx_doctestremotedata branch December 13, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: doctest-remote-data block directive hides code in Sphinx
2 participants