Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Remove CASA, fix VO ref links #14154

Merged
merged 2 commits into from Dec 9, 2022
Merged

Conversation

pllim
Copy link
Member

@pllim pllim commented Dec 9, 2022

Description

This pull request is to remove CASA from installation page and fix broken links in VO docs.

Fixes #14151

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

from installation page because it is no longer needed nor accurate.
@pllim pllim added no-changelog-entry-needed Extra CI Run cron CI as part of PR 💤 backport-v5.0.x on-merge: backport to v5.0.x 💤 backport-v5.2.x on-merge: backport to v5.2.x labels Dec 9, 2022
@pllim pllim added this to the v5.0.6 milestone Dec 9, 2022
@pllim pllim merged commit 4d6ab02 into astropy:main Dec 9, 2022
@pllim pllim deleted the doc-volinks-casapage branch December 9, 2022 17:17
@pllim
Copy link
Member Author

pllim commented Dec 9, 2022

Thanks for the review!

meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Dec 9, 2022
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Dec 9, 2022
pllim added a commit that referenced this pull request Dec 9, 2022
…154-on-v5.0.x

Backport PR #14154 on branch v5.0.x (DOC: Remove CASA, fix VO ref links)
pllim added a commit that referenced this pull request Dec 9, 2022
…154-on-v5.2.x

Backport PR #14154 on branch v5.2.x (DOC: Remove CASA, fix VO ref links)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Extra CI Run cron CI as part of PR installation io.votable no-changelog-entry-needed 💤 backport-v5.0.x on-merge: backport to v5.0.x 💤 backport-v5.2.x on-merge: backport to v5.2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CASA instructions in the docs no longer work for CASA 6
2 participants