Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual backport of PR 14142 to v5.2.x (TST: Pin tox<4) #14145

Merged
merged 1 commit into from Dec 8, 2022
Merged

Manual backport of PR 14142 to v5.2.x (TST: Pin tox<4) #14145

merged 1 commit into from Dec 8, 2022

Conversation

pllim
Copy link
Member

@pllim pllim commented Dec 8, 2022 •
edited

Description

This pull request is to manually backport #14142 to v5.2.x

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@pllim pllim added testing no-changelog-entry-needed Manual Backport skip-basebranch-check Skip base branch check for direct backports Extra CI Run cron CI as part of PR Build all wheels Run all the wheel builds rather than just a selection labels Dec 8, 2022
@pllim pllim added this to the v5.2 milestone Dec 8, 2022
@pllim pllim force-pushed the backport-of-pr14142-to-v5.2.x branch from 2c290dc to aff776f Compare December 8, 2022 14:55
@pllim

This comment was marked as off-topic.

Sign in to view
@pllim
Copy link
Member Author

pllim commented Dec 8, 2022

Daily cron remote data failure is unrelated. The fact that it got that far probably means the pin works.

@pllim pllim merged commit 6614de8 into astropy:v5.2.x Dec 8, 2022
@pllim pllim deleted the backport-of-pr14142-to-v5.2.x branch December 8, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build all wheels Run all the wheel builds rather than just a selection Extra CI Run cron CI as part of PR Manual Backport no-changelog-entry-needed skip-basebranch-check Skip base branch check for direct backports testing
Projects
None yet
Milestone
v5.2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@pllim