Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Pin tox<4 #14142

Merged
merged 1 commit into from Dec 8, 2022
Merged

TST: Pin tox<4 #14142

merged 1 commit into from Dec 8, 2022

Conversation

pllim
Copy link
Member

@pllim pllim commented Dec 7, 2022

Description

This pull request is to temporary pin to tox<4 until #14139 is ready. 馃

Also see tox-dev/tox#2612

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@pllim pllim added no-changelog-entry-needed 馃挙 backport-v5.0.x on-merge: backport to v5.0.x 馃挙 backport-v5.2.x on-merge: backport to v5.2.x labels Dec 7, 2022
@pllim pllim added this to the v5.0.6 milestone Dec 7, 2022
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

馃憢 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim pllim mentioned this pull request Dec 7, 2022
Merged
10 tasks
@pllim pllim mentioned this pull request Dec 7, 2022
Closed
pllim
pllim commented Dec 7, 2022
View reviewed changes
.github/workflows/publish.yml Outdated Show resolved Hide resolved
@pllim @Cadair
TST: Pin tox<4
0477d0f 
Co-authored-by: Stuart Mumford <stuart@cadair.com>
@pllim
Copy link
Member Author

pllim commented Dec 7, 2022

Gotta run but so far so good... 馃

@pllim pllim added Extra CI Run cron CI as part of PR Build all wheels Run all the wheel builds rather than just a selection labels Dec 7, 2022
@gaborbernat
Copy link

Can you try with 4.0.1?

@Cadair Cadair marked this pull request as ready for review December 8, 2022 10:30
@Cadair
Copy link
Member

Cadair commented Dec 8, 2022

The CI passed so I am going to merge this.

@Cadair Cadair merged commit ccdcafd into astropy:main Dec 8, 2022
@lumberbot-app

This comment was marked as resolved.

Sign in to view
@lumberbot-app

This comment was marked as resolved.

Sign in to view
@pllim pllim deleted the tox-tox-toxic branch December 8, 2022 13:37
@pllim pllim mentioned this pull request Dec 8, 2022
Closed
pllim added a commit to pllim/astropy that referenced this pull request Dec 8, 2022
@pllim
Manual backport of astropy#14142 to v5.0.x
562590f 
to pin tox<4
@pllim pllim mentioned this pull request Dec 8, 2022
Merged
10 tasks
pllim added a commit to pllim/astropy that referenced this pull request Dec 8, 2022
@pllim
Manual backport of astropy#14142 to v5.2.x
2c290dc 
to pin tox<4
@pllim pllim mentioned this pull request Dec 8, 2022
Merged
10 tasks
pllim added a commit to pllim/astropy that referenced this pull request Dec 8, 2022
@pllim
Manual backport of astropy#14142 to v5.2.x
aff776f 
to pin tox<4
pllim added a commit to pllim/astropy that referenced this pull request Dec 8, 2022
@pllim
Manual backport of astropy#14142 to v5.0.x
4cd2d07 
to pin tox<4
@mhvk
Copy link
Contributor

mhvk commented Dec 8, 2022

Thanks all for getting things to work again! And for the continuing stuff to get tox 4 to work.

pllim added a commit that referenced this pull request Dec 9, 2022
@pllim
Missed one in #14142
e4acd60 
but this missing line already applied in the backport PRs
dougbrn pushed a commit to dougbrn/astropy that referenced this pull request Mar 13, 2023
@pllim @dougbrn
Missed one in astropy#14142
a8d1636 
but this missing line already applied in the backport PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxnoe maxnoe maxnoe left review comments

@Cadair Cadair Cadair approved these changes

Assignees
No one assigned
Labels
Build all wheels Run all the wheel builds rather than just a selection Extra CI Run cron CI as part of PR no-changelog-entry-needed testing 馃挙 backport-v5.0.x on-merge: backport to v5.0.x 馃挙 backport-v5.2.x on-merge: backport to v5.2.x
Projects
None yet
Milestone
v5.0.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pllim @gaborbernat @Cadair @mhvk @maxnoe