Add speed-up values to 5.2 whats new

[maxnoe]

Description

This pull request is to address ...

Fixes #

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Do the proposed changes actually accomplish desired goals?
• Do the proposed changes follow the Astropy coding guidelines?
• Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
• Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
• Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
• Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label. Codestyle issues can be fixed by the bot.
• Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
• Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
• Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
• At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

[eerovaher]

There's a line that is a bit too long and the commits should be squashed, but the phrasing looks good enough to merge.

[pllim]

Before you squash... 😸

Suggested change

	Performance improvements will vary between different tasks, e.g. the speedup of
	Performance improvements will vary between different tasks, e.g., the speedup of

[dhomeier]

🤔

[pllim]

@astrofrog , is it too late for v5.2 ?

[astrofrog]

No, changes/improvements to docs are fine during the RC stage.

[pllim]

@maxnoe , are you interested to wrap this up? If not I can take over, pls lemme know. Thanks!

[maxnoe]

Sorry, yes, will squash

[pllim]

Thanks, all!

[pllim]

@eerovaher and @dhomeier , do you want one last look or can I merge as-is? Thanks!

[dhomeier]

I did not understand the grammar of a trailing comma after for example, but maybe that's AE vs. BE idiom.

[pllim]

ApJ used to enforce trailing comma for i.e. and e.g.. Lemme double check.

[pllim]

Well, I cannot search effectively with their new UI but they do use trailing comma after e.g. in their own style guide narrative, so I guess it still stands: https://journals.aas.org/aas-style-guide/

[dhomeier]

Well, looks like they are sold on it. My OALDC OTOH is a 1989 edition and does not even generally endorse the Oxford(!) comma. 😂

[dhomeier]

Yea, it's an Americanism https://en.wiktionary.org/wiki/e.g.#Usage_notes

[dhomeier]

Humm,

/Users/runner/work/astropy/astropy/.tox/.tox/bin/python: No module named tox

both on Actions and CircleCI??

[dhomeier]

pre-commit.ci autofix

[maxnoe]

And both here and on the other PR... seems to be some general issue.

[eerovaher]

Now it needs to be squashed.

[pllim]

Thanks, all!