Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SkipToContent appearing in URLs #1472

Closed
jwitz opened this issue Nov 11, 2022 · 1 comment · Fixed by #1612
Closed

Fix SkipToContent appearing in URLs #1472

jwitz opened this issue Nov 11, 2022 · 1 comment · Fixed by #1612
Assignees
@jwitz @katiebrady-astro
Labels
area/docs-site Non-content issues related to our website or docs infrastructure area/search Issues related to Algolia search functionality

Comments

@jwitz
Copy link
Contributor

jwitz commented Nov 11, 2022

Affected Document: All

Suggested Change (include links to relevant existing docs, support tickets, messages, or external content):

Ever since we upgraded to Docusaurus 2.2.0, the site sometimes appends skipToContent to the end of URLs. It seems to happen the most with links accessed from the search bar. I have a hunch it's related to this PR: facebook/docusaurus#8204

We should make sure our custom components are able to handle this change and not show skipToContent unless it's needed
@jwitz jwitz added the area/docs-site Non-content issues related to our website or docs infrastructure label Nov 11, 2022
@katiebrady-astro katiebrady-astro mentioned this issue Dec 9, 2022
Merged
@katiebrady-astro
Copy link
Collaborator

Hey Jake, finally have a PR open to fix this issue!

@paolaperaza paolaperaza added the area/search Issues related to Algolia search functionality label Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwitz jwitz

@katiebrady-astro katiebrady-astro

Labels
area/docs-site Non-content issues related to our website or docs infrastructure area/search Issues related to Algolia search functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug fix for SearchBar Hit astronomer/docs
3 participants
@paolaperaza @jwitz @katiebrady-astro