Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmpy2 requires libmpc-dev & libmpfr-dev #18

Open
paddyroddy opened this issue Aug 21, 2020 · 2 comments
Open

gmpy2 requires libmpc-dev & libmpfr-dev #18

paddyroddy opened this issue Aug 21, 2020 · 2 comments
Labels

Comments

@paddyroddy
Copy link
Collaborator

In my PR I neglected the fact that the gmpy2 library requires libmpc-dev & libmpfr-dev libraries #17 so either we need those in the setup.py or we should revert that PR

@paddyroddy paddyroddy added the bug label Aug 21, 2020
@jasonmcewen
Copy link
Contributor

jasonmcewen commented Sep 10, 2020

@mdavezac Just pinging you on this issue. We either need to add dependencies or revert to scipy.

@mdavezac
Copy link
Member

It's been reverted in "main" now. I guess the best way to do it would be to require only scipy, but check if gmpy2 is installed and fallback to scipy otherwise. Users can then install gmpy2 independently if they feel the need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants