Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for preview style feedback #9241

Closed
Tracked by #8678
MichaReiser opened this issue Dec 22, 2023 · 1 comment
Closed
Tracked by #8678

Ask for preview style feedback #9241

MichaReiser opened this issue Dec 22, 2023 · 1 comment
Labels
formatter Related to the formatter help wanted Contributions especially welcome

Comments

@MichaReiser
Copy link
Member

We're getting close to finishing the formatter changes for Ruff's 2024 preview style (see #8678).

A way for us to get feedback is to reach out to maintainers using Ruff's formatter by creating a PR with the formatting changes when running ruff format with --preview. The goal is not to get the PR merged (we should make this clear in the PR summary), but to review the changes ourselves and ask them if they see any changes they dislike or find questionable.

I recommend waiting for the next release or building Ruff from the source before submitting any PRs.

If anyone is interested in PRing the changes to a repository, please comment on this issue so that we can track the PRs and the feedback.

@MichaReiser MichaReiser added formatter Related to the formatter help wanted Contributions especially welcome labels Dec 22, 2023
@MichaReiser MichaReiser added this to the Formatter: Stable milestone Dec 22, 2023
@MichaReiser
Copy link
Member Author

I won't be doing this anymore because I received feedback that the primary value of Ruff/Black is that they don't need to think about formatting at all and me asking for feedback takes that value proposition for them.

I'll manually review the changes to some larger projects and make the call myself.

@MichaReiser MichaReiser closed this as not planned Won't fix, can't repro, duplicate, stale Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatter Related to the formatter help wanted Contributions especially welcome
Projects
None yet
Development

No branches or pull requests

2 participants
@MichaReiser and others