Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter: don't break single-argument multi-line strings if the first line "fits" #6581

Closed
charliermarsh opened this issue Aug 15, 2023 · 4 comments
Labels
formatter Related to the formatter needs-decision Awaiting a decision from a maintainer

Comments

@charliermarsh
Copy link
Member

@charliermarsh
Copy link
Member Author

(This is part of preview style, so perhaps not required for now.)

@charliermarsh
Copy link
Member Author

@MichaReiser -- do we have a general opinion on preview style? My assumptions:

  • If we implement formatting that does match preview style (but doesn't match Black's stable formatting), that's okay.
  • However, preview style is currently a nice-to-have and not required to ship.

@MichaReiser
Copy link
Member

Preview style isn't a priority right now. We can implement it but we need to add a preview option first and gate the logic accordingly

@MichaReiser MichaReiser added this to the Formatter: Beta milestone Aug 17, 2023
@MichaReiser MichaReiser added the needs-decision Awaiting a decision from a maintainer label Aug 22, 2023
@MichaReiser MichaReiser removed this from the Formatter: Beta milestone Aug 22, 2023
@MichaReiser
Copy link
Member

Tracked as part of #6935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatter Related to the formatter needs-decision Awaiting a decision from a maintainer
Projects
None yet
Development

No branches or pull requests

2 participants