Q000 for multiline strings with different quotes

[samuelcolvin]

code:

    assert s.to_python(123) == (
        "123 info=SerializationInfo(include=None, exclude=None, mode='python', by_alias=True, exclude_unset=False, "
        "exclude_defaults=False, exclude_none=False, round_trip=False)"
    )

Is resulting in "Q000 Double quotes found but single quotes preferred"

As you can see the first line has a single quote in it, so needs to use double quotes, the second line doesn't but by conversion you'd expect to keep using double quotes for the whole multi-line string.

[samuelcolvin]

Tried on latest ruff, getting the same error.

[charliermarsh]

Makes sense! Thanks for filing.

[samuelcolvin]

Just for reference, same error reported on flake8-quotes by me in 2019 - zheller/flake8-quotes#82

[charliermarsh]

Hopefully I can fix it today :)

[charliermarsh]

Do you think this should be an error, or merely permitted?

    assert s.to_python(123) == (
        "123 info=SerializationInfo(include=None, exclude=None, mode='python', by_alias=True, exclude_unset=False, "
        'exclude_defaults=False, exclude_none=False, round_trip=False)'
    )

[samuelcolvin]

personally I would say an error, but I'm fine with permitted too, especially since you had to do that (or add noqa) until now.

[charliermarsh]

I did some testing -- I probably need to treat it as "permitted", because Black changes them back. That is, Black changes this:

(
    '"abc"'
    'abc'
)

...to...

(
    '"abc"'
    "abc"
)

(Black will also truncate the whitespace, but omitted that change for clarity.)

It wouldn't be a huge deal in practice, since if you're using this plugin with "double" preference, you're compatible with Black anyway; and if you're using it with "single" preference, you're already incompatible with Black. But I'd prefer to avoid the potential of introducing a fix loop.

[samuelcolvin]

agreed

[samuelcolvin]

Wonderful, thanks.

[charliermarsh]

Is there any branch etc. that I could test this on just to ensure compatibility? :)

It'll go out in tonight's release.

[samuelcolvin]

See pydantic/pydantic-core#374, there's currently a bunch of noqas.

[charliermarsh]

👍 Thanks, looking good on that branch

[samuelcolvin]

👍 (on mobile, so this is a reaction)