New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the config options for flake8-unused-arguments #1254
Comments
Yeah I can add that option. Are there others that are important to you right now? |
I would say Did you implement everything from that package? Because i see no errors on Im not sure if you implement the checks on abstract methods and dunder, but if,i probably would like to disable them. These 2 are probably less important: unused-arguments-ignore-lambdas |
Yes, we ignore overloaded and stub functions, and I think we ignore abstract methods when we can detect them (not always possible because we aren't doing deep static analysis, e.g., when extending a parent class). I'd have to review the code though. |
Are you sure that overloaded functions are ignored? With import typing
@typing.overload
def concat(a: str, b: str) -> str:
...
@typing.overload
def concat(a: int, b: int) -> str:
...
def concat(a, b):
return f"{a}{b}" on latest ruff i'm getting
|
Lemme check. |
I think I was mixing up unused arguments with missing type annotations. |
Tracking here: #1372. |
Hi, this is very useful check but we cant use it because it detects **kwargs / *args as unused.
I believe its not necessary to mark this unsued vars, as bei convention **kwargs / *args is in most cases expected to not be used as it acts as a catch all.
I have to say i never seen a codebase that prefixes that with underscore.
i was not able to use any of the config options
i tried
but no luck
The text was updated successfully, but these errors were encountered: