Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server log messages should use window/logMessage #10968

Open
dhruvmanila opened this issue Apr 16, 2024 · 2 comments · May be fixed by #11169
Open

Server log messages should use window/logMessage #10968

dhruvmanila opened this issue Apr 16, 2024 · 2 comments · May be fixed by #11169
Assignees
@snowsignal
Labels
server Related to the LSP server
Milestone
Ruff Server: Beta

Comments

@dhruvmanila
Copy link
Member

Currently, the server uses the tracing module for log messages which sends everything to stderr. This gets picked up by the client and is added to the log messages at different level regardless of the level used in the server. This level is set by the client.

Here's what VS Code shows:

2024-04-16 12:00:50.229 [info] ┐ruff_server::server::api::notifications::did_change::run{file=file:///Users/dhruv/playground/python/animation.py}
┘
2024-04-16 11:59:47.905 [info]    0.101369s ERROR ruff_server::session The following error occurred when trying to find a configuration file at `/Users/dhruv/playground/python`:
No pyproject.toml/ruff.toml/.ruff.toml file was found
   0.101425s ERROR ruff_server::session Falling back to default configuration for `/Users/dhruv/playground/python`

Here's what Neovim shows:

[START][2024-04-16 12:06:02] LSP logging initiated
[ERROR][2024-04-16 12:06:02] .../vim/lsp/rpc.lua:789	"rpc"	"/Users/dhruv/work/astral/ruff-test/target/debug/ruff"	"stderr"	"   0.001027s DEBUG ruff_server::server No workspace(s) were provided during initialization. Using the current working directory as a default workspace...\n"
[ERROR][2024-04-16 12:06:02] .../vim/lsp/rpc.lua:789	"rpc"	"/Users/dhruv/work/astral/ruff-test/target/debug/ruff"	"stderr"	"   0.041356s ERROR ruff_server::session The following error occurred when trying to find a configuration file at `/Users/dhruv/playground/python`:\nNo pyproject.toml/ruff.toml/.ruff.toml file was found\n   0.041386s ERROR ruff_server::session Falling back to default configuration for `/Users/dhruv/playground/python`\n"
[ERROR][2024-04-16 12:06:02] .../vim/lsp/rpc.lua:789	"rpc"	"/Users/dhruv/work/astral/ruff-test/target/debug/ruff"	"stderr"	"   0.044606s WARN ruff_server::server LSP client does not support dynamic capability registration - automatic configuration reloading will not be available.\n┐ruff_server::server::api::notifications::did_open::run{file=file:///Users/dhruv/playground/python/errors.py}\n┘\n"

This is not a high priority. We would need to look at all the messages using tracing and convert most of them to use the notification request instead.
@dhruvmanila dhruvmanila added the server Related to the LSP server label Apr 16, 2024
@dhruvmanila
Copy link
Member Author

cc @snowsignal

@snowsignal snowsignal self-assigned this Apr 16, 2024
@snowsignal
Copy link
Member

Thanks for opening an issue for this @dhruvmanila

@snowsignal snowsignal added this to the Ruff Server: Beta milestone Apr 16, 2024
@snowsignal snowsignal linked a pull request Apr 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snowsignal snowsignal

Labels
server Related to the LSP server
Projects
None yet
Milestone
Ruff Server: Beta
Development

Successfully merging a pull request may close this issue.

Replace tracing log functions in ruff server with LSP-compliant logging functions astral-sh/ruff
2 participants
@snowsignal @dhruvmanila