Quoted annotations should be parsed as if parenthesized #9467

charliermarsh · 2024-01-11T13:50:44Z

It was recently agreed that quoted annotations should be parsed as if they were implicitly wrapped in parentheses. So, e.g., they can contain otherwise-invalid indentation, newlines within binary operators, etc.

See: microsoft/pyright#6940 (comment)

Glyphack · 2024-02-01T19:31:27Z

Should this be implemented in the parser layer or here where we emit the warning?

dhruvmanila · 2024-03-29T02:55:30Z

I think it should be implemented in the parse_type_annotation function which is used by the AST checker to report an error if found:

ruff/crates/ruff_python_parser/src/typing.rs

Lines 22 to 44 in a0263ab

    
           /// Parse a type annotation from a string. 
        
           pub fn parse_type_annotation( 
        
               value: &str, 
        
               range: TextRange, 
        
               source: &str, 
        
           ) -> Result<(Expr, AnnotationKind)> { 
        
               let expression = &source[range]; 
        
               if str::raw_contents(expression).is_some_and(|body| body == value) { 
        
                   // The annotation is considered "simple" if and only if the raw representation (e.g., 
        
                   // `List[int]` within "List[int]") exactly matches the parsed representation. This 
        
                   // isn't the case, e.g., for implicit concatenations, or for annotations that contain 
        
                   // escaped quotes. 
        
                   let leading_quote = str::leading_quote(expression).unwrap(); 
        
                   let expr = parse_expression_starts_at(value, range.start() + leading_quote.text_len())?; 
        
                   Ok((expr, AnnotationKind::Simple)) 
        
               } else { 
        
                   // Otherwise, consider this a "complex" annotation. 
        
                   let mut expr = parse_expression(value)?; 
        
                   relocate_expr(&mut expr, range); 
        
                   Ok((expr, AnnotationKind::Complex)) 
        
               } 
        
           }

I would also suggest to look at other references of parse_type_annotation function to make sure they aren't affected in any way with this change. They shouldn't be but just to make sure :)

Glyphack · 2024-03-29T16:23:17Z

Nice, I can work on this.

charliermarsh added the parser Related to the parser label Jan 11, 2024

charliermarsh added the bug Something isn't working label Jan 29, 2024

Glyphack linked a pull request Apr 2, 2024 that will close this issue

parse stringized annotation #10742

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Quoted annotations should be parsed as if parenthesized #9467

Quoted annotations should be parsed as if parenthesized #9467

charliermarsh commented Jan 11, 2024

Glyphack commented Feb 1, 2024 •

edited

dhruvmanila commented Mar 29, 2024

Glyphack commented Mar 29, 2024

Quoted annotations should be parsed as if parenthesized #9467

Quoted annotations should be parsed as if parenthesized #9467

Comments

charliermarsh commented Jan 11, 2024

Glyphack commented Feb 1, 2024 • edited

dhruvmanila commented Mar 29, 2024

Glyphack commented Mar 29, 2024

Glyphack commented Feb 1, 2024 •

edited