Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add support for inlay hints #291

Open
pythops opened this issue Oct 22, 2023 · 2 comments
Open

Feature request: Add support for inlay hints #291

pythops opened this issue Oct 22, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@pythops
Copy link

pythops commented Oct 22, 2023

pyright has no plan to add it (see the issue here), so maybe ruff can implement it instead

@dhruvmanila
Copy link
Member

I think this capability is more useful for a full fledged language server such as Pylance and, currently, ruff-lsp is only capable of providing diagnostics, formatting and code actions. Do you have any ideas / examples where inlay hints could be helpful with the current set of capabilities ruff-lsp provides?

That said, I'll leave this open for now as it could be useful when Ruff has a deeper understanding of the Python code. For example, inferred types.

@dhruvmanila dhruvmanila added the enhancement New feature or request label Oct 23, 2023
@pythops
Copy link
Author

pythops commented Oct 23, 2023

ruff-lsp is only capable of providing diagnostics, formatting and code actions.

I hope ruff-lsp will be able to do more than that one day and maybe replace even pyright

Do you have any ideas / examples where inlay hints could be helpful with the current set of capabilities ruff-lsp provides?

thanks to its speed, I think ruff-lsp could be the right candidate for the type hints actually. The other alternatives for python are little bit slow. Plus type hints could be really useful for a code base that lacks the types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants