-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve security issue with hoek #20
Comments
Codecov requires Request, More information on the issue can be found on this issue, request/request#2926. Updating codecov will the resolve issue. Hoek 4.2.1 is patched and the latest Codecov has that version. Change https://github.com/maccelerated/node-mojang/blob/master/package.json#L29 to version 3.0.1 Might require a semver-patch release so that dependents arent affected. |
Here's Github's response. TL;DR: they've gone through and deleted the bad alerts, and promised to be better about validating if security vulnerabilities are legit before putting alerts out. Looks like you shouldn't need to do anything :-) |
It needs to be resolved, 4.2.1+ is patched. We are not on that version. Edit: I'll patch master, I'll leave it up to you to merge it into the feature branches. There should be no merge conflicts as it's simply changing codecov's version. |
Fixed ac45070 |
CVE-2018-3728
recommended: hoek ~> 5.0.3
The text was updated successfully, but these errors were encountered: