Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve security issue with hoek #20

Closed
astra137 opened this issue May 4, 2018 · 4 comments
Closed

Resolve security issue with hoek #20

astra137 opened this issue May 4, 2018 · 4 comments
Assignees

Comments

@astra137
Copy link
Owner

astra137 commented May 4, 2018

CVE-2018-3728
recommended: hoek ~> 5.0.3

@astra137 astra137 self-assigned this May 4, 2018
@dscalzi
Copy link
Collaborator

dscalzi commented May 4, 2018

Codecov requires Request,
Request requires Hawk,
Hawk requires hoek

More information on the issue can be found on this issue, request/request#2926.

Updating codecov will the resolve issue. Hoek 4.2.1 is patched and the latest Codecov has that version.

Change https://github.com/maccelerated/node-mojang/blob/master/package.json#L29 to version 3.0.1

Might require a semver-patch release so that dependents arent affected.

@JessicaSachs
Copy link

Here's Github's response. TL;DR: they've gone through and deleted the bad alerts, and promised to be better about validating if security vulnerabilities are legit before putting alerts out. Looks like you shouldn't need to do anything :-)

@dscalzi
Copy link
Collaborator

dscalzi commented May 6, 2018

It needs to be resolved, 4.2.1+ is patched. We are not on that version.
https://github.com/maccelerated/node-mojang/blob/master/package-lock.json#L4027

Edit: I'll patch master, I'll leave it up to you to merge it into the feature branches. There should be no merge conflicts as it's simply changing codecov's version.

@dscalzi
Copy link
Collaborator

dscalzi commented May 6, 2018

Fixed ac45070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants