We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Munter/netlify-plugin-hashfiles#114 shows that if a relation with just a domain in its href is checked for being canonical with the Relation.canonical getter, we can throw on attempting to call .startsWith on null at https://github.com/assetgraph/assetgraph/blob/master/lib/relations/Relation.js#L278
href
Relation.canonical
.startsWith
null
We should add a check to ensure that both hrefObj and canonicalRootObj have non-null path properties
hrefObj
canonicalRootObj
path
The text was updated successfully, but these errors were encountered:
I can't really figure out how to recreate the setup that caused this, so I'm reluctant to make a change to the code when it won't be covered by a test
Sorry, something went wrong.
No branches or pull requests
Munter/netlify-plugin-hashfiles#114 shows that if a relation with just a domain in its
href
is checked for being canonical with theRelation.canonical
getter, we can throw on attempting to call.startsWith
onnull
at https://github.com/assetgraph/assetgraph/blob/master/lib/relations/Relation.js#L278We should add a check to ensure that both
hrefObj
andcanonicalRootObj
have non-nullpath
propertiesThe text was updated successfully, but these errors were encountered: