-
-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try java 14 records with recursive comparison #2018
Comments
It is now possible to have dedicated tests relying on records with a new module under assertj-integration-tests. |
#2968 introduced a new integration test module: assertj-core-java-17 |
hello @scordio, @joel-costigliola - I would like to get involved here. The issue is a bit older, is it still relevant? If so, is it just a matter of adding tests for recursive comparison for records, and using both options for ExtractBareNamePropertyMethods? |
it is @etrandafir93, yes the idea is to play with the recursive comparison and records |
Hello @joel-costigliola, Thanks for the quick reply. I've added a few tests using a flat record, a nested record, and a double-nested record that contains a collection of objects. Are there other cases we should cover? Also, I've used the static method Assertions.setExtractBareNamePropertyMethods() to test the recursive comparison with both configurations. However, since this is a static method, the tests should not run in parallel. This is my PR link: #3241 |
Summary
The recursive comparison relied on reflection to find the values to compare, let's check it that works properly with java 14 records with bare name properties enabled or disabled.
The text was updated successfully, but these errors were encountered: