Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linesOf variants for a Path content #2618

Merged
merged 5 commits into from May 22, 2022

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented May 20, 2022

Check List:

BDDAssertions uses @since in the javadoc, but wasn't sure which version to add

@scordio
Copy link
Member

scordio commented May 20, 2022

Thanks for the fast turnaround, @StefanBratanov!

BDDAssertions uses @since in the javadoc, but wasn't sure which version to add

We're now focusing on finalizing 3.23.0, let's see if we can squeeze this PR in the release. Please use 3.23.0.

@StefanBratanov
Copy link
Contributor Author

Thanks for the fast turnaround, @StefanBratanov!

BDDAssertions uses @since in the javadoc, but wasn't sure which version to add

We're now focusing on finalizing 3.23.0, let's see if we can squeeze this PR in the release. Please use 3.23.0.

Thank you. :) Done.

@scordio scordio added this to the 3.23.0 milestone May 22, 2022
@scordio scordio merged commit 59e27a0 into assertj:main May 22, 2022
@scordio
Copy link
Member

scordio commented May 22, 2022

Thanks for your first contribution, @StefanBratanov!

@StefanBratanov StefanBratanov deleted the linesof_path_variant branch May 22, 2022 22:47
@StefanBratanov
Copy link
Contributor Author

Thanks for your first contribution, @StefanBratanov!

No worries :) I have been using AssertJ for a long time and it's great to have a chance to look at the underlying code and make changes. Thank you for making it easy to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linesOf variants for Path content
2 participants