json support for snapbox
#106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
reviewed
Jul 12, 2022
epage
reviewed
Jul 13, 2022
epage
reviewed
Jul 13, 2022
epage
reviewed
Jul 13, 2022
epage
reviewed
Jul 13, 2022
epage
reviewed
Jul 13, 2022
epage
reviewed
Jul 13, 2022
epage
reviewed
Jul 13, 2022
epage
reviewed
Jul 13, 2022
epage
reviewed
Jul 13, 2022
This was referenced Jul 13, 2022
Merged
epage
reviewed
Aug 22, 2022
Muscraft
force-pushed
the
json-support
branch
4 times, most recently
from
dff733b
to
412f969
Compare
epage
reviewed
Aug 22, 2022
epage
reviewed
Aug 23, 2022
epage
reviewed
Aug 23, 2022
epage
reviewed
Aug 23, 2022
epage
reviewed
Aug 23, 2022
Muscraft
force-pushed
the
json-support
branch
4 times, most recently
from
34859be
to
f53cd76
Compare
epage
reviewed
Sep 1, 2022
Muscraft
force-pushed
the
json-support
branch
from
f53cd76
to
7a55739
Compare
This was referenced Sep 2, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make sure I was on the right track when adding json support for
snapbox. I am a bit worried aboutData::deserializeand how ergonomic it is to add a new format. This also only looks at the file type and has no other way to set theDatavariant toJson. This currently does not add support for json specific matching. When added I will probably use something similar to cargo's json matching. There shouldn't be any breaking changes but I could be wrong and might have missed something.This is a part of #92