Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter find_case for eq_file #65

Open
epage opened this issue Jul 30, 2018 · 1 comment
Open

Smarter find_case for eq_file #65

epage opened this issue Jul 30, 2018 · 1 comment
Labels
enhancement Improve the expected

Comments

@epage
Copy link
Contributor

epage commented Jul 30, 2018

Right now, its a default implementation

Ideally

  • For Str, perform difference where applicable
    • Do we also need to do this for eval? Not sure if there is a difference
@epage epage added the enhancement Improve the expected label Jul 30, 2018
@epage epage added this to the 1.0 milestone Aug 2, 2018
@epage epage removed this from the 1.0 milestone Oct 5, 2018
@mzabaluev
Copy link

Wouldn't it be nice to make case finders composable? Something like

use predicates::str::Diff as _;

predicate::path::eq_file(p).utf8().diff()

would not change how eval works, but would modify the case finder into what DifferencePredicate uses now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve the expected
Projects
None yet
Development

No branches or pull requests

2 participants