Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: show line numbers and/or context in diffs #46

Open
epage opened this issue May 29, 2018 · 1 comment
Open

Feature: show line numbers and/or context in diffs #46

epage opened this issue May 29, 2018 · 1 comment
Labels
enhancement Improve the expected

Comments

@epage
Copy link
Contributor

epage commented May 29, 2018

@colin-kiegel from assert-rs/assert_cli#17

Just a random idea. :-)

git diffs provide some context and line numbers. If the output is really huge and lines are similar, this might be helpful - but certainly not straightforward. Should probably even be implement upstream first in the difference crate.

@@ -93,7 +93,7 @@
 #[derive(Debug)]
 pub struct Assert {
     cmd: Vec<String>,
-    expect_success: bool,
+    expect_success: Option<bool>,
     expect_exit_code: Option<i32>,
     expect_stdout: Option<OutputAssertion>,
     expect_stderr: Option<OutputAssertion>,

instead of

-    expect_success: bool,
+    expect_success: Option<bool>,
@epage epage added the enhancement Improve the expected label May 29, 2018
@epage
Copy link
Contributor Author

epage commented May 29, 2018

This is blocked on #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve the expected
Projects
None yet
Development

No branches or pull requests

1 participant