into_persistent(_if) documentation confusion

[ericcornelissen]

The documentation for .into_persistent (and .into_persistent_if) suggest you can delete a persisted TempDir by calling .close on it.

assert_fs/src/fixture/dir.rs

Lines 120 to 129 in 9c5caf2

	/// ```no_run
	/// use assert_fs::fixture::TempDir;
	///
	/// let tmp_dir = TempDir::new()
	/// .unwrap()
	/// .into_persistent();
	///
	/// // Ensure deletion happens.
	/// tmp_dir.close().unwrap();
	/// ```

However, the implementation of .close explicitly doesn't do anything when the TempDir has been persisted.

assert_fs/src/fixture/dir.rs

Line 191 in 9c5caf2

Inner::Persisted(_) => (),

So, either

1. the documentation example should be updated to clarify a persisted TempDir can't be deleted, or
2. the implementation of .close should be updated to remove persisted TempDir`.

---

Some background

I ran into this while trying to work around #51 by trying to persist-by-default and close/delete on success.

[epage]

I removed that copy/paste documentation bug in d5c06c6

[epage]

btw you might find snapbox::path::PathFixture of interest. The only thing it is missing compared to higher level stuff like trycmd is support for an env variable to control the behavior.

I personally have replaced all my uses of assert_cmd / assert_fs with snapbox.