Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Add a filter provider for TempDataAttribute to RazorPages #5979

Closed
jbagga opened this issue Mar 16, 2017 · 7 comments
Closed

Add a filter provider for TempDataAttribute to RazorPages #5979

jbagga opened this issue Mar 16, 2017 · 7 comments
Assignees
@rynowak
Labels
3 - Done feature-Razor-Pages
Milestone
2.0.0

Comments

@jbagga
Copy link
Contributor

jbagga commented Mar 16, 2017 •
edited
Loading

Related to #5600
Controllers have a TempDataApplicationModelProvider which configures the SaveTempDataPropertyFilter. RazorPages currently has a workaround but needs a similar filter provider.

Remove TempDataPropertyProvider class as discussed here

cc @rynowak @pranavkm
@jbagga jbagga mentioned this issue Mar 16, 2017
Merged
@jbagga
Copy link
Contributor Author

jbagga commented Mar 29, 2017

cc @DamianEdwards

@DamianEdwards
Copy link
Member

Currently the workaround doesn't work on PageModel instances, so this feature is blocked right now.

@DamianEdwards
Copy link
Member

@rynowak @Eilon we need to triage and assign this one

@rynowak
Copy link
Member

rynowak commented Mar 30, 2017

@ryanbrandenburg - for now let's try to figure out if the hardcoded approach can be applied to the PageModel as well.

Treat this as a category 2.

@DamianEdwards
Copy link
Member

OK by me 👍

@ryanbrandenburg ryanbrandenburg mentioned this issue Mar 31, 2017
Merged
@rynowak rynowak mentioned this issue Apr 4, 2017
Closed
6 tasks
@rynowak rynowak added this to the 2.0.0-preview2 milestone Apr 4, 2017
@rynowak rynowak reopened this Apr 5, 2017
@rynowak
Copy link
Member

rynowak commented Apr 5, 2017

We still have cleanup to do here, we're just not implementing filters for pages in preview-1.

@rynowak rynowak added 1 - Ready and removed 3 - Done labels Apr 5, 2017
@rynowak rynowak self-assigned this May 23, 2017
@rynowak rynowak modified the milestones: 2.0.0-preview2, 2.0.0-preview3 May 30, 2017
rynowak added a commit that referenced this issue Jun 9, 2017
@rynowak
Fix #5979 - Remove hardcoding of tempdata for pages
758fce1
@rynowak
Copy link
Member

rynowak commented Jun 12, 2017

dfe04bc

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rynowak rynowak

Labels
3 - Done feature-Razor-Pages
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
5 participants
@Eilon @DamianEdwards @rynowak @jbagga @ryanbrandenburg