From 35d2ab37f733228af54e20d2cb2a056392e1adb4 Mon Sep 17 00:00:00 2001
From: Pranav K <prkrishn@hotmail.com>
Date: Fri, 26 Oct 2018 13:46:36 -0700
Subject: [PATCH] Allow passing a dictionary to ValidationProblemDetails

Fixes https://github.com/aspnet/Mvc/issues/8645
---
 .../ValidationProblemDetails.cs               | 21 ++++++++++++-
 .../ValidationProblemDetailsTest.cs           | 30 +++++++++++++++++++
 2 files changed, 50 insertions(+), 1 deletion(-)

diff --git a/src/Microsoft.AspNetCore.Mvc.Core/ValidationProblemDetails.cs b/src/Microsoft.AspNetCore.Mvc.Core/ValidationProblemDetails.cs
index da104c9a9b..56fdd49e9d 100644
--- a/src/Microsoft.AspNetCore.Mvc.Core/ValidationProblemDetails.cs
+++ b/src/Microsoft.AspNetCore.Mvc.Core/ValidationProblemDetails.cs
@@ -22,6 +22,10 @@ public ValidationProblemDetails()
             Title = Resources.ValidationProblemDescription_Title;
         }
 
+        /// <summary>
+        /// Initializes a new instance of <see cref="ValidationProblemDetails"/> using the specified <paramref name="modelState"/>.
+        /// </summary>
+        /// <param name="modelState"><see cref="ModelStateDictionary"/> containing the validation errors.</param>
         public ValidationProblemDetails(ModelStateDictionary modelState)
             : this()
         {
@@ -63,7 +67,22 @@ string GetErrorMessage(ModelError error)
         }
 
         /// <summary>
-        /// Gets or sets the validation errors associated with this instance of <see cref="ValidationProblemDetails"/>.
+        /// Initializes a new instance of <see cref="ValidationProblemDetails"/> using the specified <paramref name="errors"/>.
+        /// </summary>
+        /// <param name="errors">The validation errors.</param>
+        public ValidationProblemDetails(IDictionary<string, string[]> errors)
+            : this()
+        {
+            if (errors == null)
+            {
+                throw new ArgumentNullException(nameof(errors));
+            }
+
+            Errors = new Dictionary<string, string[]>(errors, StringComparer.Ordinal);
+        }
+
+        /// <summary>
+        /// Gets the validation errors associated with this instance of <see cref="ValidationProblemDetails"/>.
         /// </summary>
         [JsonProperty(PropertyName = "errors")]
         public IDictionary<string, string[]> Errors { get; } = new Dictionary<string, string[]>(StringComparer.Ordinal);
diff --git a/test/Microsoft.AspNetCore.Mvc.Core.Test/ValidationProblemDetailsTest.cs b/test/Microsoft.AspNetCore.Mvc.Core.Test/ValidationProblemDetailsTest.cs
index af4f0d9a34..9c8f296d60 100644
--- a/test/Microsoft.AspNetCore.Mvc.Core.Test/ValidationProblemDetailsTest.cs
+++ b/test/Microsoft.AspNetCore.Mvc.Core.Test/ValidationProblemDetailsTest.cs
@@ -2,6 +2,7 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
+using System.Collections.Generic;
 using Microsoft.AspNetCore.Mvc.ModelBinding;
 using Xunit;
 
@@ -73,5 +74,34 @@ public void Constructor_SerializesErrorsFromModelStateDictionary_AddsDefaultMess
                     Assert.Equal(new[] { "The input was not valid." }, item.Value);
                 });
         }
+
+        [Fact]
+        public void Constructor_CopiesPassedInDictionary()
+        {
+            // Arrange
+            var errors = new Dictionary<string, string[]>
+            {
+                ["key1"] = new[] { "error1", "error2" },
+                ["key2"] = new[] { "error3", },
+            };
+
+            // Act
+            var problemDescription = new ValidationProblemDetails(errors);
+
+            // Assert
+            Assert.Equal("One or more validation errors occurred.", problemDescription.Title);
+            Assert.Collection(
+                problemDescription.Errors,
+                item =>
+                {
+                    Assert.Equal("key1", item.Key);
+                    Assert.Equal(new[] { "error1", "error2" }, item.Value);
+                },
+                item =>
+                {
+                    Assert.Equal("key2", item.Key);
+                    Assert.Equal(new[] { "error3" }, item.Value);
+                });
+        }
     }
 }