Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Allow LibMan support in Visual Studio to be activated by a project capability #605

Open
jimmylewis opened this issue Sep 16, 2020 · 2 comments

Comments

@jimmylewis
Copy link
Contributor

jimmylewis commented Sep 16, 2020

Functional impact

This would allow any project to opt-in to libman support (context menu items, add library wizard).

Minimal repro steps

  1. Create a Razor Class Library project
  2. Try to add a library via LibMan wizard (e.g. for image assets)

Expected result

Some way to allow enabling the LibMan wizard.

Actual result

Editing libman.json works, but there's no way to get the wizard to work.

Further technical details

Enabling LibMan via a project capability means that anyone could edit their project file, even if not a web project, to opt-in to LibMan support.

Since the editor support works as long as there's a libman.json file, this issue is mostly to see if there's interest in enabling wizard support in other project types.

@TFTomSun
Copy link

TFTomSun commented Mar 12, 2021

there is a workaround for razor class libs:

<Project Sdk="Microsoft.NET.Sdk.Razor;Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <TargetFramework>net5.0</TargetFramework>
    <OutputType>Library</OutputType>
  </PropertyGroup>
  <ItemGroup>
    <FrameworkReference Remove="Microsoft.AspNetCore.App" />
  </ItemGroup>

.... could be packed into an SDK

@rouke-broersma
Copy link

Couldn't you just enable the UI as soon as a libman.json file is found?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants